feat: add registering and serializing icons#7063
Merged
BeksOmega merged 9 commits intoMay 15, 2023
Merged
Conversation
github-actions
Bot
added
PR: feature
BeksOmega
force-pushed
the
feat/registering-icons
branch
from
e28120b to
2179032
Compare
github-actions
Bot
added
PR: feature
BeksOmega
force-pushed
the
feat/registering-icons
branch
from
eea36bf to
2a5c007
Compare
BeksOmega
force-pushed
the
feat/registering-icons
branch
from
2a5c007 to
db2ad5e
Compare
BeksOmega
force-pushed
the
feat/registering-icons
branch
from
db2ad5e to
0cfe577
Compare
github-actions
Bot
added
PR: feature
BeksOmega
requested review from
rachel-fenichel
and removed request for
maribethb
| return createUninitializedBlock(workspace); | ||
| } | ||
|
|
||
| suite.skip('Hooks getting properly triggered by the block', function () { |
Collaborator
There was a problem hiding this comment.
Is this still supposed to be skipped?
Contributor
Author
There was a problem hiding this comment.
Yes, this still hasn't been implemented. It'll get fixed when I migrate over the first built-in icon (or right before).
rachel-fenichel
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7062
Proposed Changes
Adds the ability to register icons. Also adds the ability to serialize and deserialize them.
Reason for Changes
Sometimes you want icons to be serializable, so we should support that!
Test Coverage
Added tests for serialization and deserialization.
Documentation
N/A
Additional Information
Dependent on #7059