feat: make getWorkspace, getFlyout, and getToolbox public#6666
Conversation
Amusingly Flyout.isVisible and .setVisible are public, but there's no way to access a flyout given that getFlyout was not public.
|
This LGTM but reassigned approval to Maribeth since this is a design decision. Also relevant forum link for context: https://groups.google.com/g/blockly/c/31Om9fkkAWA/m/fQuAg2-JBAAJ |
maribethb
left a comment
There was a problem hiding this comment.
LGTM, but as Rachel said in the forum post, this is not just a documentation change, since we are formalizing these as part of the API. Even before TypeScript, these were marked @package so even though they have been used and recommended publicly they have never been actually declared as such.
So I would rename this PR: feat: make getWorkspace, getFlyout, and getToolbox public to make better release notes.
getWorkspace, getFlyout, and getToolbox public
|
Because I really enjoy admiring Chesterton's Fence: do we know why these were originally |
I looked at the original PR (#771) and couldn't find a reason. |
|
Back then we didn't really talk about the flyout as a public API. There weren't any ways to customize it. |
Amusingly Flyout.isVisible and .setVisible are public, but there's no way to access a flyout given that getFlyout was not public.