Skip to content

Debug configurability#2935

Merged
rachel-fenichel merged 1 commit into
RaspberryPiFoundation:developfrom
rachel-fenichel:spacer_after_statement
Aug 29, 2019
Merged

Debug configurability#2935
rachel-fenichel merged 1 commit into
RaspberryPiFoundation:developfrom
rachel-fenichel:spacer_after_statement

Conversation

@rachel-fenichel

Copy link
Copy Markdown
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#2904

Proposed Changes

Add a single property that turns debug rendering on and off
Move all the css directly into the debugger file, just to silo it
Put the config object into a getting so it's easy to change

Reason for Changes

The debugger would be more useful if it were less painful to use.

@samelhusseini samelhusseini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rachel-fenichel rachel-fenichel merged commit 3b81cb3 into RaspberryPiFoundation:develop Aug 29, 2019
@rachel-fenichel rachel-fenichel deleted the spacer_after_statement branch August 29, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants