Fixed Flyout Scrollbars Not Being Repositioned on Window Resize#2281
Merged
rachel-fenichel merged 1 commit intoFeb 11, 2019
Merged
Conversation
BeksOmega
force-pushed
the
fixes/FlyoutScrollbarAnchors
branch
from
3548c01 to
627c521
Compare
Collaborator
|
LGTM, though we really need a better way of figuring out when metrics updates actually matter, and when scrollbars need to update. |
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#1445
Proposed Changes
Adds an extra call to setPosition.
Reason for Changes
Resize would fail because the metrics were the same. This means setPosition would never get called so the scrollbar would stay in the same position.
Test Coverage
Tested on:
Additional Information
N/A