Add support for attachment flags #9486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapptz
requested changes
Jul 14, 2023
Owner
Rapptz
left a comment
Rapptz
left a comment
There was a problem hiding this comment.
In the library is_ methods are always methods, i.e. callable. Since these are properties/flags you need to remove the is_ prefix.
As those are always methods. Rapptz#9486 (review)
Rapptz
approved these changes
Jul 15, 2023
Comment on lines
+1887
to
+1895
| @flag_value | ||
| def clip(self): | ||
| """:class:`bool`: Returns ``True`` if the attachment is a clip.""" | ||
| return 1 << 0 | ||
|
|
||
| @flag_value | ||
| def thumbnail(self): | ||
| """:class:`bool`: Returns ``True`` if the attachment is a thumbnail.""" | ||
| return 1 << 1 |
Owner
There was a problem hiding this comment.
I know these are undocumented on Discord's side but it sure would be nice to know what these even are for better documentation and maybe better naming, but this won't block this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for attachment flags.
Depends on discord/discord-api-docs#6272
Checklist