Refactor: we now call PlayerManager.tickAll() directly.#385
Open
markscho wants to merge 1 commit intoRanvierMUD:masterfrom
Open
Refactor: we now call PlayerManager.tickAll() directly.#385markscho wants to merge 1 commit intoRanvierMUD:masterfrom
markscho wants to merge 1 commit intoRanvierMUD:masterfrom
Conversation
seanohue
approved these changes
Apr 27, 2021
NKjoep
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is doing a
PlayerManager.emit('updateTick')when it could be doingPlayerManager.tickAll(). That's because the updateTick event ONLY is doing a .tickAll().This seems unnecessary and makes it more consistent with how we're calling
AreaManager.tickAll()andItemManager.tickAll()at set intervals.