Refactoring Settings enumeration to be dynamically generated #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralim
force-pushed
the
settings-tool
branch
3 times, most recently
from
902125b to
3496c6c
Compare
Ralim
force-pushed
the
settings-tool
branch
2 times, most recently
from
773d14b to
da7afc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is moving us towards generating the settings lookup table dynamically at compile time; so we can easily add per-model defaults.
As well as allowing a cli tool to read/write/generate pre-load files.
What is the new behavior (if this is a feature change)?
Other information:
Have diffed generated code to existing code with not change (sans formatting)