Introduce a default-enabled cli feature
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this function is not strictly CLI related, move it into a more fitting place.
With our biggest user, `avr-device` switching to using this crate as a library rather than a CLI tool, it's time to somewhat pivot our dependency management towards this usecase. There is no need to pull in all the CLI frontend dependencies for library users. Introduce a new `cli` feature for the CLI interface. This feature is enabled by default so the tool can still be built without issue as needed. Library-only users like `avr-device` can disable the `cli` feature to reduce the number of unnecessary dependencies.
For the regression tests, drop the `cli` feature to ensure such a build works, too. For covering the CLI, add a new job which builds and runs the CLI tool.
This was referenced May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our biggest user,
avr-deviceswitching to using this crate as a library rather than a CLI tool, it's time to somewhat pivot our dependency management towards this usecase. There is no need to pull in all the CLI frontend dependencies for library users.Introduce a new
clifeature for the CLI interface. This feature is enabled by default so the tool can still be built without issue as needed. Library-only users likeavr-devicecan disable theclifeature to reduce the number of unnecessary dependencies.