Skip to content

Assign gpu pools only to test actions #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Assign gpu pools only to test actions #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab51796
Assign gpu pools only to test actions
alekstheod Oct 31, 2025
f602bd5
Ignore flaky tests
alekstheod Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions build_tools/rocm/run_xla_multi_gpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,17 @@ if [ ! -d /tf/pkg ]; then
fi

EXCLUDED_TESTS=(
CollectiveOpsTestE2E.MemcpyP2pLargeMessage
RaggedAllToAllTest/RaggedAllToAllTest.RaggedAllToAll_8GPUs_2ReplicasPerGroups/sync_decomposer
RaggedAllToAllTest/RaggedAllToAllTest.RaggedAllToAll_8GPUs_2ReplicasPerGroups/async_decomposer
# //xla/tests:collective_ops_test_amdgpu_any
RaggedAllToAllTest*
AsyncCollectiveOps*
AsyncMemcpyCollectiveOps*
CollectiveOpsTest*
AllReduceTest*
Fp8CollectiveOpsTest*
# //xla/backends/gpu/codegen/triton:fusion_emitter_parametrized_legacy_test_amdgpu_any
ElementwiseTestSuiteF32/BinaryElementwiseTest.ElementwiseFusionExecutesCorrectly/f32_atan2
# //xla/tests:collective_ops_e2e_test_amdgpu_any
CollectiveOpsTestE2E.MemcpyP2pLargeMessage
CollectiveOpsTestE2EPipelinedNonPipelined.CollectivePipelinerBackward
CollectiveOpsTestE2EPipelinedNonPipelined.CollectivePipelinerBackwardStartFromOne
# //xla/tools/multihost_hlo_runner:functional_hlo_runner_test
Expand All @@ -87,20 +92,6 @@ elif [[ $1 == "tsan" ]]; then
SANITIZER_ARGS+=("--run_under=//build_tools/rocm:sanitizer_wrapper")
SANITIZER_ARGS+=("--config=tsan")
TAG_FILTERS="$TAG_FILTERS,-notsan"
# excluded from tsan
EXCLUDED_TESTS+=(
CollectiveOpsTest*
Fp8CollectiveOpsTest.AllGather_8BitFloat
Fp8CollectiveOpsTest.CollectivePermute_8BitFloat
Fp8CollectiveOpsTest.AllToAll_8BitFloat
AsyncCollectiveOps*
AllReduceTest*
RaggedAllToAllTest*
AsyncCollectiveOps*
AsyncMemcpyCollectiveOps*
RaggedAllToAllTest*
)

# tsan tests appear to be flaky in rbe due to the heavy load
# force them to run locally
RBE_OPTIONS+=(
Expand Down
5 changes: 4 additions & 1 deletion xla/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2806,7 +2806,10 @@ xla_test(
],
},
backends = ["gpu"],
tags = ["test_migrated_to_hlo_runner_pjrt"],
tags = [
"test_migrated_to_hlo_runner_pjrt",
"local",
],
deps = [
":hlo_pjrt_test_base",
":literal_test_util",
Expand Down
4 changes: 2 additions & 2 deletions xla/tsl/platform/default/build_config_root.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ GPU_TEST_PROPERTIES = {
}

ROCM_SINGLE_GPU_TEST_PROPERTIES = {
"Pool": "linux_x64_gpu",
"test.Pool": "linux_x64_gpu",
}

ROCM_MULTI_GPU_TEST_PROPERTIES = {
"Pool": "linux_x64_multigpu",
"test.Pool": "linux_x64_multigpu",
}

def tf_gpu_tests_tags():
Expand Down