Skip to content

Fix build due to missing rocm-smi #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rocm-jaxlib-v0.7.1-old
Choose a base branch
from
+6 −14
Open

Fix build due to missing rocm-smi #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0254178
Fix build due to missing rocm-smi
alekstheod Oct 6, 2025
a4b5559
Address review changes
alekstheod Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions build_tools/rocm/run_xla.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,10 @@ set -x
N_BUILD_JOBS=$(grep -c ^processor /proc/cpuinfo)
# If rocm-smi exists locally (it should) use it to find
# out how many GPUs we have to test with.
rocm-smi -i
STATUS=$?
if [ $STATUS -ne 0 ]; then TF_GPU_COUNT=1; else
TF_GPU_COUNT=$(rocm-smi -i|grep 'Device ID' |grep 'GPU' |wc -l)
fi
TF_GPU_COUNT=$(lspci | grep -e 'controller' -e 'accelerators' | grep 'AMD/ATI' | wc -l)
TF_TESTS_PER_GPU=1
N_TEST_JOBS=$(expr ${TF_GPU_COUNT} \* ${TF_TESTS_PER_GPU})
amdgpuname=(`rocminfo | grep gfx | head -n 1`)
amdgpuname=(`/opt/rocm/bin/rocminfo | grep gfx | head -n 1`)
AMD_GPU_GFX_ID=${amdgpuname[1]}
echo ""
echo "Bazel will use ${N_BUILD_JOBS} concurrent build job(s) and ${N_TEST_JOBS} concurrent test job(s) for gpu ${AMD_GPU_GFX_ID}."
Expand All @@ -41,7 +37,7 @@ export PYTHON_BIN_PATH=`which python3`
export TF_NEED_ROCM=1
export ROCM_PATH="/opt/rocm"

GPU_NAME=(`rocminfo | grep -m 1 gfx`)
GPU_NAME=(`/opt/rocm/bin/rocminfo | grep -m 1 gfx`)
GPU_NAME=${GPU_NAME[1]}

EXCLUDED_TESTS=(
Expand Down
10 changes: 3 additions & 7 deletions build_tools/rocm/run_xla_multi_gpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,20 @@ set -x
N_BUILD_JOBS=$(grep -c ^processor /proc/cpuinfo)
# If rocm-smi exists locally (it should) use it to find
# out how many GPUs we have to test with.
rocm-smi -i
STATUS=$?
if [ $STATUS -ne 0 ]; then TF_GPU_COUNT=1; else
TF_GPU_COUNT=$(rocm-smi -i|grep 'Device ID' |grep 'GPU' |wc -l)
fi
TF_GPU_COUNT=$(lspci | grep -e 'controller' -e 'accelerators' | grep 'AMD/ATI' | wc -l)
if [[ $TF_GPU_COUNT -lt 4 ]]; then
echo "Found only ${TF_GPU_COUNT} gpus, multi-gpu tests need atleast 4 gpus."
exit
fi

amdgpuname=(`rocminfo | grep gfx | head -n 1`)
amdgpuname=(`/opt/rocm/bin/rocminfo | grep gfx | head -n 1`)
AMD_GPU_GFX_ID=${amdgpuname[1]}

export PYTHON_BIN_PATH=`which python3`
export TF_NEED_ROCM=1
export ROCM_PATH="/opt/rocm"

GPU_NAME=(`rocminfo | grep -m 1 gfx`)
GPU_NAME=(`/opt/rocm/bin/rocminfo | grep -m 1 gfx`)
GPU_NAME=${GPU_NAME[1]}

BAZEL_DISK_CACHE_SIZE=100G
Expand Down