Remove unused tsan ignores #360
Open
+6
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstheod
force-pushed
the
ci_fix_tsan_issues
branch
from
a726193 to
ca0f4c6
Compare
There was a problem hiding this comment.
Pull Request Overview
Removes unused Thread Sanitizer (TSAN) ignore entries and related code changes as part of code cleanup.
- Removes 4 unused TSAN ignore rules from the ignore list
- Comments out CudnnFusedConvRewriter usage in AMD GPU compiler
- Updates test configuration to be CUDA-specific only
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build_tools/rocm/tsan_ignore_list.txt | Removes 4 unused TSAN ignore entries |
| xla/service/gpu/amdgpu_compiler.cc | Comments out CudnnFusedConvRewriter usage |
| xla/service/gpu/transforms/BUILD | Makes cudnn_fused_conv_rewriter_test CUDA-only |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| auto rcc = std::get<se::RocmComputeCapability>(gpu_version); | ||
| pipeline.AddPass<CudnnFusedConvRewriter>(rcc, dnn_version, toolkit_version); | ||
| // auto rcc = std::get<se::RocmComputeCapability>(gpu_version); | ||
| // pipeline.AddPass<CudnnFusedConvRewriter>(rcc, dnn_version, toolkit_version); |
There was a problem hiding this comment.
Commented-out code should be removed rather than left as comments. If this code needs to be preserved for future reference, consider documenting the reason in a TODO comment or tracking it in an issue.
Suggested change
| // pipeline.AddPass<CudnnFusedConvRewriter>(rcc, dnn_version, toolkit_version); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused tsan ignores