warpSize fix port to ROCm-7.0 #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits included: Using cuda_compat to defint the WARP_SIZE once Signed-off-by: Gregory Shtrasberg <[email protected]> On ROCm toe constant compile time warp size can not be used on the host side that can be shared for multiple architectures with different values Signed-off-by: Gregory Shtrasberg <[email protected]> Formatting Signed-off-by: Gregory Shtrasberg <[email protected]> Refactor to use cuda_compat, and not the unhippified version Signed-off-by: Gregory Shtrasberg <[email protected]> Leaving CUDA side as just a simple define Signed-off-by: Gregory Shtrasberg <[email protected]>
gshtras
requested review from
charlifu,
hongxiayang,
maleksan85,
mawong-amd,
shajrawi and
sunway513
as code owners
shajrawi
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over vllm-project#20330 and vllm-project#21205
Commits included:
Using cuda_compat to defint the WARP_SIZE once
On ROCm toe constant compile time warp size can not be used on the host side that can be shared for multiple architectures with different values
Formatting
Refactor to use cuda_compat, and not the unhippified version
Leaving CUDA side as just a simple define