Skip to content

add emtpy_cache() after each padding #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2024
Merged

add emtpy_cache() after each padding #120

merged 2 commits into from
Aug 6, 2024

Conversation

@charlifu
Copy link

@charlifu charlifu commented Aug 6, 2024 •
edited
Loading

Pytorch caches the memory for unused tensor after each padding, use torch.cuda.empty_cache() to release the memory.

@charlifu charlifu requested a review from shajrawi August 6, 2024 19:15
shajrawi
shajrawi approved these changes Aug 6, 2024
View reviewed changes
Copy link

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@charlifu charlifu merged commit 98f31cd into main Aug 6, 2024
@gshtras gshtras deleted the charlifu/fix_padding branch August 20, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shajrawi shajrawi shajrawi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charlifu @shajrawi