SWDEV-546177 - hipModuleGetLoadingMode API impl#653
Open
SWDEV-546177 - hipModuleGetLoadingMode API impl#653
Conversation
anugodavar
pushed a commit
that referenced
this pull request
Aug 20, 2025
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false * SWDEV-539414 - default handler when GPU core file is generated * SWDEV-540576 - Abort if user request a core dump Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3 --------- Co-authored-by: Assiouras, Ioannis <[email protected]> Co-authored-by: agunashe <[email protected]> [ROCm/clr commit: 9c1bff0]
mattwill-amd
pushed a commit
that referenced
this pull request
Aug 20, 2025
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false * SWDEV-539414 - default handler when GPU core file is generated * SWDEV-540576 - Abort if user request a core dump Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3 --------- Co-authored-by: Assiouras, Ioannis <[email protected]> Co-authored-by: agunashe <[email protected]>
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
from
de311e1 to
18240b2
Compare
This was referenced Aug 22, 2025
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
2 times, most recently
from
332693f to
4b3a6e3
Compare
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
3 times, most recently
from
5329cbd to
bdb99d6
Compare
Contributor
|
@agunashe are you incrementing the HIP_RUNTIME_API_TABLE_STEP_VERSION for this new function for the rocprofiler-sdk ABI code? If not, could you do so? |
1 task
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
2 times, most recently
from
4bc5efd to
12abe95
Compare
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
agunashe
force-pushed
the
amd/dev/agunashe/SWDEV-546177_impl
branch
from
12abe95 to
75fd9df
Compare
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
[ROCm/rocdecode commit: 92bf931]
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the HIP runtime API hipModuleGetLoadingMode and wires it through the HIP dispatch table / rocprofiler ABI, plus adds unit tests and related lazy/eager module-loading plumbing.
Changes:
- Add
hipModuleGetLoadingModeto HIP headers, dispatch table, export lists, and rocprofiler SDK API metadata/ABI enforcement. - Introduce module loading mode flag (
HIP_MODULE_LOADING) and use it to drive eager vs lazy population of dynamic module globals/functions. - Add new HIP unit tests for
hipModuleGetLoadingMode.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/hip.def.cpp | Registers the new runtime API in rocprofiler’s HIP API table metadata (guarded by step version). |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp | Extends ABI enforcement/versioning for the new dispatch-table entry. |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hip/runtime_api_id.h | Adds a new runtime API id enum entry for hipModuleGetLoadingMode. |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/hip/api_args.h | Adds args struct for hipModuleGetLoadingMode to the union. |
| projects/rocprofiler-sdk/source/include/rocprofiler-sdk/cxx/enum_string.hpp | Adds string label + version static_assert for the new API id. |
| projects/hipother/hipnv/include/hip/nvidia_detail/nvidia_hip_runtime_api.h | Adds CUDA-backend implementation mapping to cuModuleGetLoadingMode. |
| projects/hip/include/hip/hip_runtime_api.h | Adds hipModuleLoadingMode_t enum and declares hipModuleGetLoadingMode with doxygen. |
| projects/hip-tests/catch/unit/module/hipModuleGetLoadingMode.cc | New unit tests for default/eager mode and kernel execution behavior. |
| projects/hip-tests/catch/unit/module/CMakeLists.txt | Adds the new test source to the module unit tests list. |
| projects/clr/rocclr/device/devprogram.cpp | Refactors COMGR symbol name fetching to only do the work for matching symbol types. |
| projects/clr/hipamd/src/hip_table_interface.cpp | Adds public API thunk calling the dispatch-table function pointer. |
| projects/clr/hipamd/src/hip_platform.hpp / hip_platform.cpp | Adds PlatformState::getLoadingMode logic based on HIP_MODULE_LOADING. |
| projects/clr/hipamd/src/hip_module.cpp | Implements hipModuleGetLoadingMode in the AMD runtime. |
| projects/clr/hipamd/src/hip_hcc.map.in / amdhip.def | Exports the new API symbol. |
| projects/clr/hipamd/src/hip_code_object.hpp / hip_code_object.cpp | Adds lazy/eager loading behavior for dynamic code objects (deferred population). |
| projects/clr/hipamd/src/hip_api_trace.cpp / include/hip_api_trace.hpp | Extends dispatch table, ABI checks, and version to step 26. |
| projects/clr/hipamd/include/hip/amd_detail/hip_prof_str.h | Extends profiler/tracer metadata with new API id, args, and string formatting. |
| projects/clr/CHANGELOG.md | Documents the newly added HIP API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gandryey
approved these changes
Feb 26, 2026
chrispaquot
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API hipModuleGetLoadingMode implementation
Technical Details
API hipModuleGetLoadingMode implementation
Test Plan
rocprofiler and hip tests pass sucessfully
Test Result
NA
Submission Checklist