Draft
Conversation
github-actions
bot
added
project: amdsmi
github actions
amd-juwillia
force-pushed
the
juwillia/python-final
branch
from
859f2ef to
57593b8
Compare
marifamd
force-pushed
the
juwillia/python-final
branch
from
57593b8 to
b4a0d5a
Compare
amd-juwillia
force-pushed
the
juwillia/python-final
branch
from
b4a0d5a to
4d9a212
Compare
Signed-off-by: Justin Williams <[email protected]>
marifamd
force-pushed
the
juwillia/python-final
branch
from
b549d6e to
9639199
Compare
Signed-off-by: Maisam Arif <[email protected]>
marifamd
force-pushed
the
juwillia/python-final
branch
2 times, most recently
from
bef95b3 to
5618d07
Compare
- Link amdsminic static library into libamd_smi_python.so to resolve undefined NIC symbols - Prevent pip-context wrapper from falling back to system libamd_smi.so to avoid dual-loading segfault - Add trailing newline to setup.cfg.in
amd-juwillia
force-pushed
the
juwillia/python-final
branch
from
5618d07 to
87e9051
Compare
Signed-off-by: Justin Williams <[email protected]>
amd-juwillia
force-pushed
the
juwillia/python-final
branch
from
ed79383 to
68aa824
Compare
Signed-off-by: Justin Williams <[email protected]>
amd-juwillia
force-pushed
the
juwillia/python-final
branch
from
68aa824 to
b0dc79f
Compare
adam360x
requested changes
Mar 11, 2026
| except Exception: | ||
| _log_version_and_path_diagnostics() | ||
| print("[amdsmi-cli] Failed to read amdsmi Python package version; aborting to avoid incompatibility.") | ||
| sys.exit(1) |
Contributor
There was a problem hiding this comment.
This is where my code is failing to run in the container. Once we get this fixed I will approve as the rest looks great
| class struct_amdsmi_pcie_info_t(Structure): | ||
| pass | ||
|
|
||
| class struct_pcie_static_(Structure): |
Contributor
There was a problem hiding this comment.
This is unrelated to this PR, did you have a stray commit in here? I think we'd want to have this separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.