Add missing counter events handling for ROCPD#1305
Merged
dgaliffiAMD merged 4 commits intodevelopfrom Oct 16, 2025
Merged
Conversation
dgaliffiAMD
approved these changes
Oct 10, 2025
Contributor
dgaliffiAMD
left a comment
dgaliffiAMD
left a comment
There was a problem hiding this comment.
Looks good. Thank you. Just a couple of comments.
projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
Outdated
Show resolved
Hide resolved
…cprofiler-sdk/counters.cpp
…cprofiler-sdk/counters.cpp
Signed-off-by: David Galiffi <[email protected]>
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Oct 16, 2025
* Add missing counter events handling for ROCPD * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Fixed formatting Signed-off-by: David Galiffi <[email protected]> [rocm-systems] ROCm/rocm-systems#1305 (commit f2ccc96)
dgaliffiAMD
added a commit
that referenced
this pull request
Oct 17, 2025
* Add missing counter events handling for ROCPD * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Fixed formatting Signed-off-by: David Galiffi <[email protected]> --------- Signed-off-by: Marjan Antic <[email protected]> Co-authored-by: David Galiffi <[email protected]>
1 task
shahamed
pushed a commit
that referenced
this pull request
Oct 22, 2025
* Add missing counter events handling for ROCPD * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Fixed formatting Signed-off-by: David Galiffi <[email protected]> --------- Signed-off-by: Marjan Antic <[email protected]> Co-authored-by: David Galiffi <[email protected]>
dgaliffiAMD
added a commit
that referenced
this pull request
Nov 5, 2025
* Add missing counter events handling for ROCPD * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Fixed formatting Signed-off-by: David Galiffi <[email protected]> --------- Signed-off-by: Marjan Antic <[email protected]> Co-authored-by: David Galiffi <[email protected]>
JeniferC99
pushed a commit
that referenced
this pull request
Nov 6, 2025
* [rocprofiler-systems] [ROCpd] Add OMPT callbacks to ROCpd (#1016) * Add OMPT to ROCpd * Use correct category * Added wrapper functions for future control * Formatting * Fix naming * Comment change * Remove ompt_get_cb_args * Switched to using region_sample for OMPT * Remove relic function * Remove get_use_rocpd that was used in this pr (one still remains) * Rename ompt_get_args_string and reuse in tool_tracing_callback_stop * Make lock init and destroy cb instant * [Prototype] ROCPD Name fix * [Prototype] ROCPD Name fix P1 * [Prototype] ROCPD Name fix P2 * ROCPD Name fix * Var name changes * Rewrite cb overwrite to single function * [Important] Use parallel_data as key for parallel callback map * Fix workflow failure * Make cpp USE_ROCM consistent with hpp and use default constructor if USE_ROCM = 0 * Add missing ROCPROFILER_VERSION check * Improve readability * Make ompt storage maps thread local * Part 1: Variable name fix, memory cleanup, and fixed asserts * Part 2: Add comments * Part 3: Add CI_THROW * Part 4: Formatting * Part 5: Move #include to cpp * Add missing counter events handling for ROCPD (#1305) * Add missing counter events handling for ROCPD * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Update projects/rocprofiler-systems/source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp * Fixed formatting Signed-off-by: David Galiffi <[email protected]> --------- Signed-off-by: Marjan Antic <[email protected]> Co-authored-by: David Galiffi <[email protected]> * Update VERSION to 1.2.1 * Update CHANGELOG.md * Add caching of category region for rocpd (#1420) * Add caching of category region Fix vaapi traces Remove region_with_name * Applied suggestions from code review * Add some simple rocpd testing Signed-off-by: David Galiffi <[email protected]> * Adjust `rocpd_string` validation parameters * Adjust `rocm_marker_api` validation parameters * Update projects/rocprofiler-systems/CHANGELOG.md Co-authored-by: Pratik Basyal <[email protected]> * Update projects/rocprofiler-systems/CHANGELOG.md Co-authored-by: Pratik Basyal <[email protected]> * Update projects/rocprofiler-systems/CHANGELOG.md Co-authored-by: Pratik Basyal <[email protected]> --------- Signed-off-by: Marjan Antic <[email protected]> Signed-off-by: David Galiffi <[email protected]> Co-authored-by: Kian Cossettini <[email protected]> Co-authored-by: marantic-amd <[email protected]> Co-authored-by: Milan Radosavljevic <[email protected]> Co-authored-by: Pratik Basyal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The counter events are missing from the rocpd implementation. For SWDEV-556438.
Technical Details
Added counter events handling as pmc events. Storing it into rocpd database. Minor changes to the counter component.
Test Plan
Test Result
Existing tests passed.
Submission Checklist