Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the nlohmann JSON library to CI Docker images across multiple Linux distributions (Ubuntu, RHEL, and openSUSE) to support dependencies for the rocm-systems project.
- Adds nlohmann JSON development packages to all CI Dockerfiles
- Uses distribution-specific package names for the JSON library
- Maintains existing package installation structure and formatting
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-systems/docker/Dockerfile.ubuntu.ci | Adds nlohmann-json3-dev to Ubuntu CI package list |
| projects/rocprofiler-systems/docker/Dockerfile.ubuntu | Adds nlohmann-json3-dev to Ubuntu package list |
| projects/rocprofiler-systems/docker/Dockerfile.rhel.ci | Adds json-devel to RHEL CI package list |
| projects/rocprofiler-systems/docker/Dockerfile.rhel | Adds json-devel to RHEL package list |
| projects/rocprofiler-systems/docker/Dockerfile.opensuse.ci | Adds nlohmann_json-devel to openSUSE CI package list |
| projects/rocprofiler-systems/docker/Dockerfile.opensuse | Adds nlohmann_json-devel to openSUSE package list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Maybe we can also include Ubuntu/Debian: |
Fixes error during conda installation. ``` CondaValueError: You have chosen a non-default solver backend (libmamba) but it was not recognized. Choose one of: classic ```
dgaliffiAMD
changed the title
nlohmann-json-devel on CI dockersThere was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Updated OS_VERSION check used in pip install
dgaliffiAMD
force-pushed
the
users/dgaliffi/docker-install-json
branch
from
444b444 to
3feb196
Compare
- Add `nlohmann-json-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu. - Add `gmock-dev` and `gtest-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu. - Add `--set solver classic` to conda config to resolve an issue setting up the conda environment - Fix Perfetto package installation on ubuntu noble image. - Add a check and log error if pip installation fail [rocm-systems] ROCm/rocm-systems#1202 (commit c0f8627)
Motivation
Installing json library in Dockerfiles for #1033.
Installing other packages what will be used soon.
Fixing CI container update workflow.
Technical Details
Add
nlohmann-json-dev(or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.Add
gmock-devandgtest-dev(or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.Add
--set solver classicto conda config to resolve an issue setting up the conda environmentTest Plan
Running update Docker workflow to update all of our CI dockers and perform a test build with each.
Test Result
Submission Checklist