Fixed issues with nic-performance test#1168
Merged
dgaliffiAMD merged 22 commits intoROCm:developfrom Oct 15, 2025
Merged
Conversation
dgaliffiAMD
reviewed
Oct 4, 2025
dgaliffiAMD
force-pushed
the
ajanicijamd/nic-performance-ctest-failing
branch
from
6a3cab7 to
d08b0b4
Compare
Co-authored-by: David Galiffi <[email protected]>
Getting the list of default NICs by running a script. Co-authored-by: David Galiffi <[email protected]>
Co-authored-by: David Galiffi <[email protected]>
Co-authored-by: David Galiffi <[email protected]>
…janicijamd/nic-performance-ctest-failing
github-actions
bot
added
the
github actions
dgaliffiAMD
approved these changes
Oct 9, 2025
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Oct 15, 2025
- On some hosts the wget can finish too soon and PAPI doesn't catch even a single network event. - On some hosts, there are multiple default NICs and the scripts didn't work in that case. - The test script was writing the output of wget to /tmp directory, which causes a problem if another user tries to run the same test. Because the output file with the same name already exists in the same directory, but with a different owner, the test fails [rocm-systems] ROCm/rocm-systems#1168 (commit 259ef63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the following issues with nic-performance test:
Technical Details
Test Plan
Test Result
Submission Checklist