Skip to content
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
d3a9b15
Add OMPT to ROCpd
kcossett-amd Sep 16, 2025
e70f59b
Use correct category
kcossett-amd Sep 16, 2025
9926233
Added wrapper functions for future control
kcossett-amd Sep 17, 2025
cdd3212
Formatting
kcossett-amd Sep 17, 2025
9cc79af
Fix naming
kcossett-amd Sep 17, 2025
2cb7b97
Comment change
kcossett-amd Sep 17, 2025
ffba5db
Remove ompt_get_cb_args
kcossett-amd Sep 17, 2025
94e22f8
Switched to using region_sample for OMPT
kcossett-amd Sep 18, 2025
fa74e17
Remove relic function
kcossett-amd Sep 18, 2025
6f12f01
Remove get_use_rocpd that was used in this pr (one still remains)
kcossett-amd Sep 19, 2025
d2308b1
Rename ompt_get_args_string and reuse in tool_tracing_callback_stop
kcossett-amd Sep 19, 2025
9c13e25
Make lock init and destroy cb instant
kcossett-amd Sep 21, 2025
ace8715
[Prototype] ROCPD Name fix
kcossett-amd Sep 21, 2025
f326946
[Prototype] ROCPD Name fix P1
kcossett-amd Sep 22, 2025
8b3a93b
[Prototype] ROCPD Name fix P2
kcossett-amd Sep 22, 2025
76365db
ROCPD Name fix
kcossett-amd Sep 23, 2025
88eaefe
Var name changes
kcossett-amd Sep 24, 2025
2fe7792
Rewrite cb overwrite to single function
kcossett-amd Sep 24, 2025
37408bb
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Sep 24, 2025
a1d6a0e
[Important] Use parallel_data as key for parallel callback map
kcossett-amd Sep 24, 2025
944928b
Fix workflow failure
kcossett-amd Sep 24, 2025
5e70ad4
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Sep 24, 2025
7046ea5
Make cpp USE_ROCM consistent with hpp and use default constructor if …
kcossett-amd Sep 24, 2025
1c02b33
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Sep 24, 2025
4cca350
Add missing ROCPROFILER_VERSION check
kcossett-amd Sep 25, 2025
00070cd
Improve readability
kcossett-amd Sep 29, 2025
1372fe3
Make ompt storage maps thread local
kcossett-amd Sep 29, 2025
ef4b82d
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Sep 29, 2025
f61f3ef
Part 1: Variable name fix, memory cleanup, and fixed asserts
kcossett-amd Oct 5, 2025
ef77830
Part 2: Add comments
kcossett-amd Oct 5, 2025
d5b0088
Part 3: Add CI_THROW
kcossett-amd Oct 5, 2025
f3d620d
Part 4: Formatting
kcossett-amd Oct 6, 2025
0dafa85
Part 5: Move #include to cpp
kcossett-amd Oct 6, 2025
1a99122
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Oct 6, 2025
9de089f
Merge branch 'develop' into users/kcossett-amd/rocpd-ompt
kcossett-amd Oct 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,54 @@ metadata_registry::get_kernel_symbol_list() const
return result;
}

metadata_registry::metadata_registry()
{
auto items = m_callback_tracing_info.items();
std::vector<std::string_view> cat_backup;
std::vector<std::string_view> ompt_new_op_name;

cat_backup.reserve(items.size());
for(size_t i = 0; i < items.size(); i++)
{
const auto* category = items[i];
cat_backup.push_back(category->name);

if(category->value == ROCPROFILER_CALLBACK_TRACING_OMPT)
{
auto operations = category->items();
ompt_new_op_name.reserve(operations.size());

for(size_t j = 0; j < operations.size(); j++)
{
const auto& [op_idx, op_name_ptr] = operations[j];
ompt_new_op_name.push_back(*op_name_ptr);
}
}
}

// Override
ompt_new_op_name[static_cast<size_t>(ROCPROFILER_OMPT_ID_parallel_begin)] =
"omp_parallel";
ompt_new_op_name[static_cast<size_t>(ROCPROFILER_OMPT_ID_parallel_end)] =
"omp_parallel";

// Rewrite OMPT entry
for(size_t i = 0; i < static_cast<size_t>(ROCPROFILER_OMPT_ID_LAST); i++)
{
m_callback_tracing_info.emplace(ROCPROFILER_CALLBACK_TRACING_OMPT,
static_cast<rocprofiler_ompt_operation_t>(i),
ompt_new_op_name[i].data());
}

// Add back all categories after OMPT entry
for(size_t i = static_cast<size_t>(ROCPROFILER_CALLBACK_TRACING_OMPT) + 1;
i < static_cast<size_t>(ROCPROFILER_CALLBACK_TRACING_LAST); i++)
{
auto enum_value = static_cast<rocprofiler_callback_tracing_kind_t>(i);
m_callback_tracing_info.emplace(enum_value, cat_backup[i].data());
}
}

rocprofiler::sdk::buffer_name_info_t<const char*>
metadata_registry::get_buffer_name_info() const
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ struct metadata_registry

private:
friend class cache_manager;
metadata_registry() = default;
metadata_registry();
common::synchronized<info::process> m_process;
common::synchronized<
std::unordered_set<info::pmc, info::pmc_info_hash, info::pmc_info_equal>>
Expand Down
Loading
Loading