unify cmake_minimum_required versions and allow 4.0#260
Merged
cgmb merged 1 commit intoROCm:developfrom Sep 23, 2025
Merged
Conversation
ROCm#222 attempted to implement compatibility with newer CMake versions by bumping the minimum required version, however the cmake_minimum_required calls in subdirs that are intended to support standalone builds were missed. Unifying these and allowing 4.0 as I've tested that policy version works. Fixes ROCm#259
Contributor
Author
|
CI seems to be broken, unrelated to this PR. Seeing the same Mfree error as #256 (comment) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
cc @amd-jnovotny @bcornille
Motivation
Building with CMake 4 should work.
Technical Details
#222 attempted to implement compatibility with newer CMake versions by bumping the minimum required version, however the cmake_minimum_required calls in subdirs that are intended to support standalone builds were missed.
Unifying these and allowing 4.0 as I've tested that policy version works.
Test Plan
Rebuild of nixpkgs ROCm package set atop CMake 4.
Test Result
hipfort builds successfully
Submission Checklist