-
Notifications
You must be signed in to change notification settings - Fork 248
Dlejeune/ck tile 2d multiple reductions #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for multi-reduction kernels to the CK_TILE library, enabling multiple reduction operations to be performed simultaneously on tensors. The implementation includes both threadwise and multiblock reduction variants, with supporting infrastructure for code generation, testing, and examples.
- Implements
MultiReduceThreadWiseandMultiReduceMultiblockkernels for GPU reduction operations - Adds a CMake-based code generation system that creates test instances from JSON configurations
- Provides comprehensive test coverage with both threadwise and multiblock implementations
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tile_engine/ops/reduce/reduce_instance_builder.py |
Code generator for test instances using configuration-driven approach |
tile_engine/ops/reduce/reduce_config.py |
Configuration loader for reduction kernel parameters |
tile_engine/ops/reduce/CMakeLists.txt |
Build system integration with Python code generation |
tile_engine/ops/CMakeLists.txt |
Added reduce subdirectory to build |
test/ck_tile/reduce/test_multi_reduce2d_* |
Test infrastructure for both threadwise and multiblock kernels |
include/ck_tile/ops/reduce/kernel/multi_reduce2d_* |
Core kernel implementations |
include/ck_tile/host/reference/reference_reduce.hpp |
Reference implementations for validation |
include/ck_tile/ops/reduce.hpp |
Updated API surface with new kernel includes |
example/ck_tile/05_reduce/multiple_reduce_*.cpp |
Example applications demonstrating usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
Implementation of multi reduce ops, both in a threadwise or multiblock (aka blockwise) fashion. It migrate most of the feature already present in old CK with a few exception:
Also some notable limitations are to be noted:
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files