Remove lru func in fake to avoid Symint error #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a SymInt compatibility issue in the fused_moe_fake function by removing the call to the lru_cache-decorated get_inter_dim helper function. The lru_cache decorator causes errors when tensor shapes contain symbolic integers (SymInt) used during PyTorch compilation/tracing.
- Replaced
get_inter_dim(w1.shape, w2.shape)call with direct extraction ofmodel_dimfromw2.shape[1] - Removed unused variables
Eandinter_dimfrom the fake function implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valarLip
approved these changes
Nov 18, 2025
zhuyuhua-v
pushed a commit
that referenced
this pull request
Nov 22, 2025
zhuyuhua-v
pushed a commit
that referenced
this pull request
Nov 22, 2025
zhuyuhua-v
pushed a commit
that referenced
this pull request
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist