Bump rocm-systems 20251119 #2220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ScottTodd, the current status is:
|
ScottTodd
reviewed
Nov 21, 2025
Comment on lines
295
to
+311
| therock_test_validate_shared_lib( | ||
| PATH ocl-clr/dist/lib | ||
| PATH ocl-clr/dist/lib/opencl | ||
| LIB_NAMES | ||
| libamdocl64.so | ||
| ) | ||
|
|
||
| # Ensure runtime dependencies of libamdocl64.so (for example, | ||
| # libamd_comgr_loader.so) are discoverable by the dynamic loader when | ||
| # running the validation test. Some configurations (e.g. Windows) do not | ||
| # register this test, so guard the property update accordingly. | ||
| if(TEST therock-validate-shared-lib-libamdocl64.so) | ||
| set_tests_properties(therock-validate-shared-lib-libamdocl64.so | ||
| PROPERTIES | ||
| ENVIRONMENT | ||
| "LD_LIBRARY_PATH=${CMAKE_BINARY_DIR}/core/ocl-clr/dist/lib:$ENV{LD_LIBRARY_PATH}" | ||
| ) | ||
| endif() |
Member
There was a problem hiding this comment.
Something feels off here. I think I saw a comment from @stellaraccident saying these build tests weren't necessarily still useful? Is this the right fix for the test if we do want to keep it?
Here are the logs for the test before these changes: https://github.com/ROCm/TheRock/actions/runs/19525189297/job/55965734381#step:13:63
24/26 Test #24: therock-validate-shared-lib-libhiprtc.so .............. Passed 0.04 sec
Start 25: therock-validate-shared-lib-libamdocl64.so
25/26 Test #25: therock-validate-shared-lib-libamdocl64.so ............***Failed 0.03 sec
Validating shared library: /__w/TheRock/TheRock/build/core/ocl-clr/dist/lib/libamdocl64.soTraceback (most recent call last):
File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 24, in <module>
main(sys.argv[1:])
File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 20, in main
run(args)
File "/__w/TheRock/TheRock/build_tools/validate_shared_library.py", line 12, in run
so = ctypes.cdll.LoadLibrary(shared_lib)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/python/cp312-cp312/lib/python3.12/ctypes/__init__.py", line 460, in LoadLibrary
return self._dlltype(name)
^^^^^^^^^^^^^^^^^^^
File "/opt/python/cp312-cp312/lib/python3.12/ctypes/__init__.py", line 379, in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: /__w/TheRock/TheRock/build/core/ocl-clr/dist/lib/libamdocl64.so: cannot open shared object file: No such file or directory
Start 26: therock-examples-cpp-sdk-user
26/26 Test #26: therock-examples-cpp-sdk-user ......................... Passed 4.03 sec
96% tests passed, 1 tests failed out of 26
Total Test time (real) = 4.86 sec
The following tests FAILED:
25 - therock-validate-shared-lib-libamdocl64.so (Failed)
Contributor
Author
There was a problem hiding this comment.
As a summary, there were two problems as far as I understand:
- The test was looking in
dist/lib/libamdocl64.sobut the actual file was indist/lib/opencl/libamdocl64.so - Even after pointing the test at the correct libamdocl64.so, the dynamic linker still couldn’t load it because its runtime dependencies (for example libamd_comgr_loader.so.1) weren’t on the library search path when CTest runs.
ScottTodd
approved these changes
Nov 21, 2025
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
OK to unblock updates to rocm-systems. Let's follow up on the libamdocl64.so test though.
Contributor
Author
Thanks - I opened an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump rocm-systems 20251119