Increase rocWMMA smoke test timeout #2192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the test machines are busy this can take a lot longer.
Contributor
Author
|
Example of this timing out: https://github.com/ROCm/rocm-libraries/actions/runs/19473725132/job/55734422616?pr=2691 |
stellaraccident
approved these changes
Nov 19, 2025
ScottTodd
reviewed
Nov 20, 2025
| # If we need something even faster we can use "/smoke" here. | ||
| test_subdir = "/regression" | ||
| timeout = "300" | ||
| timeout = "900" |
Member
There was a problem hiding this comment.
This PR has conflicts to resolve now, fyi.
d4fd7cb increased the timeout to 720. Do we still want 900?
Contributor
Author
There was a problem hiding this comment.
I suspect the 12min timeout will be sufficient. Once the refs are bumped in rocm-libraries we should have a better idea. I'll keep this open until we know it's not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The original timeout worked well when the test machines were not too busy. More time is needed for the smoke tests when the test machines are very busy.
Technical Details
Test Plan
Test Result
Submission Checklist