Skip to content

Conversation

@umarinkovic
Copy link
Contributor

@umarinkovic umarinkovic commented Nov 17, 2025

Motivation

Issue: #977

Technical Details

Added hipify artifacts to rocm_sdk_core package.
Added hipify-clang, hipify-perl to the CLI.
Added the rpath to the libllvm.so.22 required for running hipify-clang.

Test Plan

Built locally on Linux, installed packages, ran hipify-clang --version and hipify-perl version.

Test Result

[root@7fd1ca02b379 src]# hipify-clang --version
AMD LLVM version 22.0.0git
  Optimized build.
[root@7fd1ca02b379 src]# hipify-perl --version
HIP version 7.0.0

Submission Checklist

Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before landing, please add a test to build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py

(at least for hipify-clang. hipify-perl is best effort with respect to system installed packages)

@umarinkovic
Copy link
Contributor Author

umarinkovic commented Nov 18, 2025

@stellaraccident
@ScottTodd

Slight problem when testing on Windows,

def hipify_perl():
    _exec("bin/hipify-perl")

this won't work, because _exec relies on the shebang for executing scripts.

Two solutions come to mind, either

  1. only exposing hipify-perl on Linux, or
  2. adding a function that allows for the executing of scripts using a specific interpreter, here:
    def _exec(relpath: str):
    full_path = PLATFORM_PATH / (relpath + exe_suffix)
    os.execv(full_path, [str(full_path)] + sys.argv[1:])

@ScottTodd
Copy link
Member

Approved + triggered workflows. Will try to remember to merge after they run/pass.

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be passing now. Will wait for a few more of the workflows to finish before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants