-
Notifications
You must be signed in to change notification settings - Fork 128
Add hipify to rocm_sdk_core package #2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
stellaraccident
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before landing, please add a test to build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py
(at least for hipify-clang. hipify-perl is best effort with respect to system installed packages)
|
Slight problem when testing on Windows, def hipify_perl():
_exec("bin/hipify-perl")this won't work, because Two solutions come to mind, either
|
|
Approved + triggered workflows. Will try to remember to merge after they run/pass. |
build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py
Outdated
Show resolved
Hide resolved
build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py
Outdated
Show resolved
Hide resolved
ScottTodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem to be passing now. Will wait for a few more of the workflows to finish before merging.
Motivation
Issue: #977
Technical Details
Added
hipifyartifacts torocm_sdk_corepackage.Added
hipify-clang,hipify-perlto the CLI.Added the rpath to the
libllvm.so.22required for runninghipify-clang.Test Plan
Built locally on Linux, installed packages, ran
hipify-clang --versionandhipify-perl version.Test Result
Submission Checklist