-
Notifications
You must be signed in to change notification settings - Fork 87
Suppress verbose output #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: humble
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @CaioContiG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses excessive terminal output during training and testing of the DQN agent. It achieves this by setting verbose=0 in model.predict() calls within dqn_agent.py and dqn_test.py. Additionally, debugging print() statements have been removed from dqn_test.py, and a consistent print statement has been added to the test phase to align with the training phase, providing more informative output during testing.
Highlights
- Reduce Verbosity: Suppresses excessive terminal output by setting
verbose=0inmodel.predict()calls during training and testing in bothdqn_agent.pyanddqn_test.py. - Clean Up Debugging Statements: Removes debugging
print()statements fromdqn_test.pyto reduce clutter in the output. - Improve Test Output: Adds a consistent
print()statement in the test phase ofdqn_test.pyto provide informative feedback, similar to the training phase.
Changelog
Click here to see the changelog
- turtlebot3_dqn/turtlebot3_dqn/dqn_agent.py
- Set
verbose=0inmodel.predict()calls within theprocess(),get_action(), andtrain_model()methods to suppress excessive output. - Line 154: Modified
self.model.predict(state)toself.model.predict(state, verbose=0)in theprocessmethod. - Line 249: Modified
self.model.predict(state)toself.model.predict(state, verbose=0)in theget_actionmethod. - Line 251: Modified
self.model.predict(state)toself.model.predict(state, verbose=0)in theget_actionmethod. - Line 303: Modified
self.model.predict(current_states)toself.model.predict(current_states, verbose=0)in thetrain_modelmethod. - Line 307: Modified
self.target_model.predict(next_states)toself.target_model.predict(next_states, verbose=0)in thetrain_modelmethod.
- Set
- turtlebot3_dqn/turtlebot3_dqn/dqn_test.py
- Removed a debugging
print()statement on line 111 in theprocess()method. - Added a
print()statement within theif done:block in theprocess()method (lines 139-143) to provide episode, score, memory length, and epsilon information. - Set
verbose=0inmodel.predict()calls within theget_action()andtrain_model()methods to suppress excessive output. - Line 169: Modified
self.model.predict(state.reshape(1, len(state)))toself.model.predict(state.reshape(1, len(state)), verbose=0)in theget_actionmethod. - Line 184: Modified
self.model.predict(state.reshape(1, len(state)))toself.model.predict(state.reshape(1, len(state)), verbose=0)in thetrain_modelmethod. - Line 188: Modified
self.model.predict(next_state.reshape(1, len(next_state)))toself.model.predict(next_state.reshape(1, len(next_state)), verbose=0)in thetrain_modelmethod. - Line 190: Modified
self.target_model.predict(next_state.reshape(1, len(next_state)))toself.target_model.predict(next_state.reshape(1, len(next_state)), verbose=0)in thetrain_modelmethod.
- Removed a debugging
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The prints were verbose,
A silent model's the verse,
Less noise, more learning.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to reduce verbosity during training and testing by suppressing excessive terminal output and removing debugging print statements. The changes look good overall, but there are a few minor suggestions for improvement.
Merge Readiness
The changes in this pull request seem reasonable and address the issue of excessive terminal output during training and testing. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. I recommend merging this pull request.
Suppresses excessive terminal output by setting verbose=0 in model.predict() calls during training and testing. It also removes print() statements likely intended for debugging and adds a consistent print() statement message in the test phase to align with the training phase.