Skip to content

toolchain/gnu: also define NM [backport 2018.07] #9632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cladmi merged 1 commit into from
Jul 25, 2018
Merged

toolchain/gnu: also define NM [backport 2018.07] #9632

cladmi merged 1 commit into from
Jul 25, 2018

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jul 25, 2018

Backport of #9624

Contribution description

Define NM when TOOLCHAIN=gnu

llvm is defining NM already and openthread is using the symbol.

Testing

With this PR you correctly have an output for info-debug-variable-NM with TOOLCHAIN=gnu

make --no-print-directory -C examples/hello-world/ BOARD=samr21-xpro info-debug-variable-NM TOOLCHAIN=gnu
arm-none-eabi-nm

make --no-print-directory -C examples/hello-world/ BOARD=samr21-xpro info-debug-variable-NM TOOLCHAIN=llvm
llvm-nm

make --no-print-directory -C examples/hello-world/ BOARD=native info-debug-variable-NM TOOLCHAIN=gnu 
nm

make --no-print-directory -C examples/hello-world/ BOARD=native info-debug-variable-NM TOOLCHAIN=llvm
llvm-nm

Issues/PRs references

Used in #9599

@cladmi
toolchain/gnu: also define NM
de856fd 
llvm is defining NM already and `openthread` is using the symbol.

(cherry picked from commit cde5a91)
@cladmi cladmi added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 25, 2018
@cladmi cladmi requested a review from jcarrano July 25, 2018 11:40
This was referenced Jul 25, 2018
Merged
Merged
jcarrano
jcarrano approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok (same as #9624)

@cladmi cladmi merged commit b0faa34 into RIOT-OS:2018.07-branch Jul 25, 2018
@cladmi cladmi deleted the 2018.07/pr/make/nm branch July 25, 2018 12:49
@cladmi cladmi added this to the Release 2018.07 milestone Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcarrano jcarrano jcarrano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: release backport Integration Process: The PR is a release backport of a change previously provided to master

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @jcarrano