boards/arduino-atmega-common: use PD7 for ctx operations #7594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously configured to PC5 which is shared with the i2c SCL line. PD7 is selected since it's the only pin which does not have an additional function.
lebrush
added
Platform: AVR
Member
|
Just a quick question: Is it a good idea to have such things in the common part of the board? Isn't it better to have it per board as different boards with the same CPU might have a confliect as well? |
Member
Author
|
Yes, good point. I thought about the same, there's a lot of mixed code for the Atmega MCUs... I suggest to leave this PR as is, since just fixes the pin, I will open a new one refactoring these definition board based to start discussion on that. |
smlng
approved these changes
Sep 18, 2017
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
Untested ACK, but looks good according to 328p data sheet. I agree with both of you, this should got into cpu instead of board, but also: atmega config is currently a mess and needs improvement.
Member
lebrush
added
the
CI: ready for build
Member
Author
|
And go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously configured to PC5 which is shared with the i2c
SCL line. PD7 is selected since it's the only pin which does not
have an additional function.