Conversation
kaspar030
added
State: WIP
kaspar030
force-pushed
the
remove_old_net
branch
from
6be9034 to
3c5e34a
Compare
|
kaspar030
force-pushed
the
remove_old_net
branch
from
3c5e34a to
ddd9d13
Compare
kaspar030
added
the
CI: ready for build
|
NACK - I'm against removing ccn-lite and cc2420 completely without having a commitment of someone to re-import this within the next three months. |
kaspar030
force-pushed
the
remove_old_net
branch
from
f519254 to
fea8bae
Compare
|
@OlegHahm So you're against what we decided three weeks ago (removal of the old network stack)? The code is not gone. It is just kicked out of master. The old functionality will still be there for all eternity (good luck, github!), nicely tagged, for everyone interested in using today's RIOT together with cc2420 edit and ccn-lite. |
|
I'm against removing ccn-lite and drivers that are mostly unrelated to the old or the new network stack without any commitment of re-import them soonish.
Which is basically the same thing. No-one will use invisible, unmaintained code. |
I'd prefer keeping them in, too, but it is not that easy. Guys, anyone keen on nitpicking all the coding convention breaches and other problems of an evolving RIOT, expressing feelings of "rather not", please let's not make the burden of supporting legacy stuff so big that RIOT will just stagnate feature wise. The old network code is legacy. We cannot support it. |
|
I don't see any burden with this particular code, seems more like FUD statement. |
cc2420 uses the old transceiver interface... |
|
IMHO we could use #3417 to assign certain features that will be lost during the transition to certain people. This way, features won't be lost forever and we will have something to use as a lookup in case we need a reminder. However, this still requires that we check on this list regularly in order to not lose the goal out of sight |
|
Travis is happy for everything but tests/coap on avr8, which is being blacklisted in #3562. |
kaspar030
removed
the
State: WIP
kaspar030
force-pushed
the
remove_old_net
branch
from
8cd76f9 to
a00bcb5
Compare
|
|
+13 −32,369 👍 |
|
sys/Makefile.include: remove net_help entry, ieee802154 entry, |
kaspar030
force-pushed
the
remove_old_net
branch
from
7a82a7b to
c6a4599
Compare
|
kaspar030
force-pushed
the
remove_old_net
branch
from
657c398 to
443c4ce
Compare
|
(@OlegHahm's issues sorted out while having lunch) |
|
Travis is happy. Could you guys please take another look? @authmillenon? @haukepetersen? |
(will be upgraded to gnrc soon)
for
- avsextrem
- redbee-econotag
- spark-core
- telosb
- z1
kaspar030
force-pushed
the
remove_old_net
branch
from
c2310c3 to
f9ee9da
Compare
|
|
I'd say, merge... |
OlegHahm
removed
the
CI: needs squashing
|
oops, accidentally hit the Travis restart button... |
|
It was green, I saw it :-) |
|
We could try to formulate this: Is anyone against merging this PR? @authmillenon ? |
|
go ahead! It might make sense to squash a little bit, but I do not really have an opinion on this... |
|
If everything is green: go ahead an merge. I'm with @kaspar030: the only way to test it is to compile the remaining apps. If you want and in-depth look at the list of removed files you have to wait a little: the mobile interface complains: "can't show full diff, too many files changed" ^^ |
|
YEAH! |
|
Update the web page accordingly. Let me know if I missed something. |
|
YES! |
|
Bittersweet (since it removed s a lot of old code of mine) yay! |
6 participants
This is my WIP branch for removing the legacy stack. Feel free to PR more removals against this, or just ignore.