rust: Update riot-sys selectively to fix C2Rust incompatibility [backport 2025.10] #21870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the package just so far that the changes from [60] (fixing compatibility with C2Rust 0.21) are in, but not [61] (which caused yet to be understood trouble on native32 builds). [60]: RIOT-OS/rust-riot-sys#60 [61]: RIOT-OS/rust-riot-sys#61 (cherry picked from commit 45aba94)
maribu
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
maribu
added
Area: Rust
crasbe
approved these changes
Nov 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21867
Contribution description
This updates the package just so far that the changes from 60 (fixing compatibility with C2Rust 0.21) are in, but not 61 (which caused yet to be understood trouble on native32 builds).
In this, it is a subset of #21840, which will need to be re-run onto this later.
This PR is prioritized over 21840 because the fixes should be backportable to the upcoming release.
Testing procedure
I'm tied up in other projects, and did not test this. In particular, I think that this will need a runtime testing on native32 (probably running all the examples once, and in gcoap running some CoAP request) because I have a hunch that the troubles in #21840 that require disabling native32 might not be bugs, but actually new checks that detect alignment or size issues. Testing should at least show if that is an acute problem.
Issues/PRs references
Breaks: #21840