Skip to content

boards: migrate ESP32 based boards to common board module system #21835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

boards: migrate ESP32 based boards to common board module system #21835

merged 1 commit into from
Nov 18, 2025
+131 −166

Conversation

@crasbe
Copy link
Contributor

@crasbe crasbe commented Oct 30, 2025 •
edited
Loading

Contribution description

This adapts the ESP32 based boards to the common boards system introduced in #21327, where only the USEMODULE has to be specified instead of manually adding the directory and including the Makefiles. (Well, Makefile.features still has to be included, as explained in #21334).

Testing procedure

All boards should still build and work as before.

Issues/PRs references

Tracking Issue: #21331

@crasbe crasbe added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2025
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: boards Area: Board ports labels Oct 30, 2025
@crasbe crasbe added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: no fast fail don't abort PR build after first error and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2025
@crasbe crasbe force-pushed the pr/esp32_common_module branch from 755c1bc to ff6abd9 Compare October 30, 2025 15:58
@riot-ci
Copy link

riot-ci commented Oct 30, 2025 •
edited
Loading

Murdock results

✔️ PASSED

9d3cfc2 boards: migrate ESP32 based boards to common board module system

Success Failures Total Runtime
10932 0 10932 10m:22s

Artifacts

@crasbe crasbe removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Oct 30, 2025
AnnsAnns
AnnsAnns approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a basic overview, I don't feel confident enough to be the guiding approval on this though. I'd be happy if somebody else would take a look that actually worked on esp32 related stuff.

AnnsAnns
AnnsAnns approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@AnnsAnns AnnsAnns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it builds, passes tests and nobody else reviewed it in the last weeks, I'd rather approve it than for it to go stale. Feel free to squash/remove .murdock change

@crasbe crasbe force-pushed the pr/esp32_common_module branch from ff6abd9 to 9d3cfc2 Compare November 18, 2025 11:22
@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Nov 18, 2025
@crasbe crasbe enabled auto-merge November 18, 2025 11:22
@crasbe crasbe added this pull request to the merge queue Nov 18, 2025
Merged via the queue into RIOT-OS:master with commit 9c578c8 Nov 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnsAnns AnnsAnns AnnsAnns approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crasbe @riot-ci @AnnsAnns