sys/shell: expose readline() #21505
Merged
sys/shell: expose readline() #21505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teufelchen1
approved these changes
May 23, 2025
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
Easy!
I would be happy to merge it as is but if you feel like fixing the static test errors that would be nice.
derMihai
force-pushed
the
mir/export_readline
branch
from
8c9c4c8 to
b149bfb
Compare
Teufelchen1
added
the
CI: ready for build
crasbe
added
the
Type: enhancement
mguetschow
requested changes
May 23, 2025
| * @return EOF, if the end of the input stream was reached. | ||
| * @return -ENOBUFS if the buffer size was exceeded. | ||
| */ | ||
| int readline(char *buf, size_t size); |
Contributor
There was a problem hiding this comment.
Suggested change
| int readline(char *buf, size_t size); | |
| int shell_read_line(char *buf, size_t size); |
as we usually prefix all functions with their module name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
For interactive shell commands,
readline()is very useful as it provides robust line fetching from the console and is already externally linked. This PR just declares it inshell.hTesting procedure
Nothing to be tested.