tests/sys/shell: skip reboot for boards using highlevel_stdio #20988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
mguetschow
added
the
CI: ready for build
benpicco
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Boards using highlevel_stdio disconnect on reboot, thereby failing the automatic python tests. The functionality to disable reboot was already there. This PR just disables it automatically when the board has the
highlevel_stdioFEATURE.Testing procedure
make -C tests/sys/shell BOARD=feather-nrf52840-sense flash testfails on master, passes with this PR
Issues/PRs references
Encountered while working on #20980