-
Notifications
You must be signed in to change notification settings - Fork 2.1k
pkg/wolfssl: bump version to 4.3.0 #13260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
46eab80 to
38d9000
Compare
|
I know it's not required RIOT policy, but it's a Debian habit I'd consider useful here: Could you mention inside the patch where it was forwarded to upstream, if so, or whether it was cherry-picked from? That should help keeping track of patches we need to keep around as opposed to those we can get rid of eventually by being good downstreams. |
chrysn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run the same tests on an nRF52840 (on the -dongle board), and they built and ran fine. I did not look into the changes in WolfSSL in particular other than skimming the change log, and there's nothing in there to indicate any downsides to an upgrade. Code size increase is, as expected, minimal (114k to 115k text for the self tests where increases might be expected, 23k by 8 byte increase for signature test).
|
tbh the patch was a bit too messy to upstream and all the different compile-time config options make it hard to get this right. But there is a much simpler solution that is employed by other pkgs too… |
e8d168b to
0d92c33
Compare
MichelRottleuthner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on native and pba-d-01-kw2x with examples/dtls-wolfssl, tests/pkg_wolfcrypt-ed25519-verify and tests/wolfssl-test. All good, apart from examples/dtls-wolfssl but this is also the case on master.
Just one non-blocking suggestion below. ACK
Update to the latest upstream release https://www.wolfssl.com/docs/wolfssl-changelog/ This unfortunetaly introduced some unused parameter warnings, so disable the warning via CFLAGS.
Contribution description
Update to the latest upstream release
https://www.wolfssl.com/docs/wolfssl-changelog/
Unfortunately the new version introduced some unused parameter warnings, so I disabled them for this pkg.
Testing procedure
I ran both
tests/pkg_wolfsslandtests/pkg_wolfcrypt-ed25519-verifyonnativeand esp32.Issues/PRs references
none