cpu/esp32: use esptool.py from riot tools #12750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegorich
reviewed
Nov 20, 2019
yegorich
reviewed
Nov 20, 2019
yegorich
reviewed
Nov 20, 2019
Contributor
|
Successfully tested against TTGO T-Beam. |
Contributor
Author
|
@yegorich Thanks for reviewing and testing. @MrKevinWeiss This is the answer to your question, whether the modified version of the |
gschorcht
added
Area: cpu
aabadie
reviewed
Nov 20, 2019
aabadie
approved these changes
Nov 21, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
ACK, please squash!
Flashing on ESP32 works with the esptool.py provided in dist/tools (the default) and overriding ESPTOOL from the command line is also usable.
Use esptool.py from riot tools instead from ESP-IDF SDK to avoid that the SDK has to be installed to flash an image.
gschorcht
force-pushed
the
cpu/esp32/esptools
branch
from
a3a7c65 to
fe16573
Compare
Contributor
Author
|
Squashed. |
Contributor
Author
|
Thanks |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The ESP8266 port requires a modified
esptool.pyversion, which is shipped with the ESP8266 RTOS SDK and not available as git repository or distribution package. To be able to flash an image without the RTOS SDK installed, this modifiedesptool.pyversion was extracted from the RTOS SDK and added todist/tools.This modified
esptool.pyversion can also be used for the ESP32 port. Thus, it becomes possible to flash an image without the installation of the ESP-IDF SDK or a separate installation of theesptool.py.Testing procedure
Flash any application, for example
Issues/PRs references
Replaces PR #12028
Prerequisite for PR #12752