tests/log_color: fix string literal error #12510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printf function requires a string literal as the format argument. Using a character pointer is not accepted as string literal by some compilers.
gschorcht
added
Area: tests
20 tasks
aabadie
approved these changes
Oct 19, 2019
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Changes are good and required for ESP8266. Let's merge this.
ACK
Contributor
Author
|
@aabadie Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The compilation of
tests/log_colorfails with GCC version in the new toolchain for ESP8266 in PR https://github.com/RIOT-OS/riotdocker with:The reason is that this GCC version does not accept a character pointer as sting literal for the format argument in
printf. The GCC version is 5.2.0.This PR defines the format as string constant to fix the problem. It works for all other GCC version and platforms.
The problem occurred while testing PR #11108.
Testing procedure
The compilation for all platforms has to succeed.
Issues/PRs references
Required by PR #11108.