Skip to content

Conversation

@basilfx
Copy link
Member

@basilfx basilfx commented Sep 24, 2019

Contribution description

This PR exposes a global define that can be used to skip certain parts of the bootloader, when building the bootloader.

I need that for several reasons:

  • reducing the size of the bootloader (for instance, the EFM32 cpu_init() does a lot more that should not happen in the bootloader)
  • skipping parts in cpu_init() that are not relevant during boot
    • configuring clock sources
      • example: I could have an updated firmware that uses another source/configuration
    • e.g. chip applying errata
    • configuring DC-DC parameters
      • example: I decide to update DC-DC parameters to make my board more efficient or stable
    • peripheral initialization

My goal is to boot as quick as possible to the actual firmware on the defaults, and then do proper initialization.

Testing procedure

Any test that uses the riotboot bootloader should still work.

Issues/PRs references

#11940, #8902 (comment)

@basilfx basilfx added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 24, 2019
@miri64 miri64 added Area: OTA Area: Over-the-air updates Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Sep 24, 2019
@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 24, 2019
@benpicco
Copy link
Contributor

I'd say squash.

@basilfx basilfx force-pushed the feature/define_riotboot branch from 458a390 to 58e2825 Compare September 24, 2019 17:37
@basilfx
Copy link
Member Author

basilfx commented Sep 24, 2019

@benpicco Squashed and rebased.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 24, 2019
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 24, 2019
@miri64
Copy link
Member

miri64 commented Sep 24, 2019

Something went wrong on murdock:

/bin/sh: 1: ./.murdock: not found

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is tiny yet very useful - ACK.
Only adds a new define, no side effects.

@benpicco benpicco merged commit 0049e84 into RIOT-OS:master Sep 24, 2019
@basilfx
Copy link
Member Author

basilfx commented Sep 24, 2019

Thanks!

@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 29, 2019
@basilfx basilfx deleted the feature/define_riotboot branch January 14, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: OTA Area: Over-the-air updates CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants