Skip to content

pkg/lwip: include log.h if module log is used #11148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miri64 merged 1 commit into from
Mar 11, 2019
Merged

pkg/lwip: include log.h if module log is used #11148

miri64 merged 1 commit into from
Mar 11, 2019

Conversation

@gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Mar 10, 2019

Contribution description

If module log is used, log.h should be included. Otherwise, it might lead to compilation problems since LOG_ERROR macro isn't know in expansion of LWIP_PLATFORM_ASSERT macro.

Testing procedure

Just compile any lwip test application.

@gschorcht
pkg/lwip: include log.h if module log is used
cd00449 
If module log is used, log.h should be included. Otherwise, it might lead to compilation problems since LOG_ERROR macro isn't know in expansion of LWIP_PLATFORM_ASSERT macro.
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports labels Mar 10, 2019
@gschorcht gschorcht requested a review from miri64 March 10, 2019 11:49
@gschorcht gschorcht mentioned this pull request Mar 10, 2019
Merged
20 tasks
miri64
miri64 approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Makes sense.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 11, 2019
@miri64 miri64 merged commit 3742c43 into RIOT-OS:master Mar 11, 2019
@gschorcht
Copy link
Contributor Author

gschorcht commented Mar 11, 2019

Thanks

@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
@gschorcht gschorcht deleted the pkg/lwip/log_error/pr branch April 11, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2019.04

Development

Successfully merging this pull request may close these issues.

3 participants

@gschorcht @miri64 @danpetry