Skip to content

Refactor ci flow#161

Merged
dr-orlovsky merged 11 commits intoRGB-WG:masterfrom
yanganto:v0.11-msrv
May 23, 2024
Merged

Refactor ci flow#161
dr-orlovsky merged 11 commits intoRGB-WG:masterfrom
yanganto:v0.11-msrv

Conversation

@yanganto
Copy link
Contributor

@yanganto yanganto commented Apr 8, 2024

Fix MSRV issue of #160

  • Bumps MSRV
  • CI will use MSRV from Rust manifest (Cargo.toml)
  • reduce using actions-rs, which is no longer maintained after Oct 13, 2023.
  • add cli as default package, such that people can easier to use rgb with special commit or master branch by following command anywhere
    nix run github:RGB-WG/rgb -- validate <FILE> (work after this PR merged)
    nix run github:RGB-WG/rgb/9492fd3e82aaab65e77b767f09d85ab2d38a8bad -- validate <FILE>

@yanganto
Copy link
Contributor Author

yanganto commented Apr 8, 2024

@dr-orlovsky
Please be kindly reminded.
This PR will go into v0.11 not master, and solve the trivial CI issues.

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Apr 9, 2024
@yanganto yanganto marked this pull request as draft April 23, 2024 12:39
@yanganto yanganto changed the base branch from v0.11 to master April 23, 2024 12:40
@yanganto yanganto force-pushed the v0.11-msrv branch 2 times, most recently from 522612e to 9027740 Compare April 23, 2024 13:04
@yanganto yanganto changed the title ci: bump MSRV Refactor ci flow Apr 23, 2024
@codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.0%. Comparing base (f2f2b22) to head (ac2c92f).
Report is 157 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #161      +/-   ##
========================================
- Coverage    29.9%   0.0%   -29.9%     
========================================
  Files          10     10              
  Lines        1273    896     -377     
========================================
- Hits          381      0     -381     
- Misses        892    896       +4     
Flag Coverage Δ
rust 0.0% <ø> (-29.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanganto yanganto marked this pull request as ready for review April 23, 2024 13:31
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac2c92f

@dr-orlovsky dr-orlovsky merged commit 4a498cc into RGB-WG:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants