replace electrum-client with bp-electrum#150
Merged
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom Mar 19, 2024
Merged
Conversation
dr-orlovsky
reviewed
Mar 18, 2024
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
LGTM. Will release the client, and ask to change the dependency to the released version. Than we can merge this.
zoedberg
force-pushed
the
refactor_electrum
branch
from
f0549a4 to
cfac2e9
Compare
Member
Author
|
@dr-orlovsky PR updated, it's now using the released version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the electrum-client and bitcoin crates with bp-electrum. Rationale: BP-WG/bp-wallet#19 (comment)
Not sure this should be merged before the bp-electrum crate is released on crates.io, @dr-orlovsky maybe we should release that and then update and merge this PR?