Resolver Height (get by spent script)#15
Merged
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom May 17, 2023
Merged
Conversation
oacdutra
force-pushed
the
feat/resolve-height
branch
from
42803a6 to
aebfe81
Compare
dr-orlovsky
approved these changes
May 16, 2023
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK aebfe81
That is clever! Have been looking to solve electrum inability to provide tx height for long time, and never had this idea!
oacdutra
force-pushed
the
feat/resolve-height
branch
from
aebfe81 to
d75f40a
Compare
dr-orlovsky
reviewed
May 16, 2023
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
Can you pls provide than a impl From<electrum_client::Error> for Error not to duplicate the code and avoid such errors?
Member
Author
I think is not possible, because we use external information to construct the error message. |
oacdutra
force-pushed
the
feat/resolve-height
branch
from
d75f40a to
35079ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intend implement the
ResolverHeightwith combination of two electrum methods: get_transaction and batch_script_get_history.