Skip to content

invoice error for blind with no outpoint#123

Merged
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom
nicbus:invoice_error
Feb 8, 2024
Merged

invoice error for blind with no outpoint#123
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom
nicbus:invoice_error

Conversation

@nicbus
Copy link
Member

@nicbus nicbus commented Feb 7, 2024

This PR returns an error instead of silently switching to address-based mode when a blinded invoice is requested (no -a option specified) but no suitable outpoint is found.

The rationale for this is that a user can request a blinded invoice and fail to notice what the command returned is instead an address-based one. This might be the case if, as an example, the wallet had available UTXOs on keychain 0 but not on 9.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da52d4a

@dr-orlovsky
Copy link
Member

Good improvement, thank you

@dr-orlovsky dr-orlovsky merged commit 9076e4a into RGB-WG:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants