Merged
Conversation
Member
|
This is very strange. These deps should be used for reading config file and environment. If they are not it might be a bug or a code missed. I will look is it the case. |
dr-orlovsky
approved these changes
Jan 23, 2023
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK 17238b8
I confirm that this deps are not used - they come from the early days of the node. Environment is now read through std::env here - and in microservices which provides a set-up helper functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found some unused dependencies so opening this to remove them