CLI transfer combine: set_rgb_contract for blank#209
Merged
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom Oct 5, 2022
Merged
CLI transfer combine: set_rgb_contract for blank#209dr-orlovsky merged 1 commit intoRGB-WG:masterfrom
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom
Conversation
zoedberg
force-pushed
the
fix/blank_cli
branch
from
53107e5 to
dade899
Compare
zoedberg
force-pushed
the
fix/blank_cli
branch
from
dade899 to
774ed48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to
TransferCommand::CombineCLI command. While constructing blank transitions we also need to set their related rgb contracts to the psbt, otherwise the commandpsbt.rgb_bundle_to_lnpbp4()(from rgb-std), when collecting bundles by iterating onself.rgb_contract_ids(), will not collect blank bundles and therefore blank transitions will not complete succesfully.