Merged
Conversation
zoedberg
force-pushed
the
feat/disclosure_api
branch
from
bf93fe1 to
631aeb1
Compare
zoedberg
force-pushed
the
feat/disclosure_api
branch
from
631aeb1 to
2e165b5
Compare
dr-orlovsky
approved these changes
Sep 30, 2022
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
utACK 2e165b5
Wow, really clearly and well-written! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206 by adding an API,
process_disclosure, that gets the transfer TXID ad uses it to retrieve its associated disclosure and process it saving all relevant data into the DB.Moreover this PR introduces a commit that changes the key used to save
BUNDLESinto the DB, from thewitness_txidto a chunk ofcontract_idandwitness_txid, allowing the send of more assets with the same TX.I haven't added a CLI command for the new API yet, since I'm not sure the API and related naming will be accepted, but once we'll agree on details I will be happy to add that.