Conversation
|
@dr-orlovsky |
dr-orlovsky
left a comment
There was a problem hiding this comment.
I have zero experience with nix and have a hard time reviewing this change.
Overall I am not happy switching from actions-rs to third-party DeterminateSystems. I have experience with such orgs being abandoned breaking CI all across everything.
Can we start with a trivial fix of MSRV and introduce nix a bit later once I finish with other urgent stuff related to v0.11 completion?
|
Sure. I will open another quick-fix one if that is easier. I will be pleased to introduce Nix to you, once you have time. In And what Nix doing is locking every dependency also by source code for the dev shell or the build system And these are pined by https://github.com/nixos/nixpkgs and we use Then, we use I am happy to maintain the Nix CI system here because I use NixOS, so no matter whether this is merged or not. I still need a Nix dev shell on my local, or else I can not develop this project. (The flake.nix needs to be git added whenever developing, it keeps a developer from using the latest one, but I need to be remove it in every commit not to push it) |
8246a3f to
962d204
Compare
|
Few questions:
|
|
actions-rs was marked as archived by an administrator on Oct 13, 2023. It is no longer maintained. They clearly announced, so we should find another solution. Nix is a good solution to pin the Rust. No matter There is more than one GitHub action that can install the
The Nix system will build things from scratch or download them from the cache. Also, there are other cache services I have used before, we can use them to avoid using a young github action project. |
|
We can remove |
c35c135 to
eebcb7a
Compare
dr-orlovsky
left a comment
There was a problem hiding this comment.
I am failing to understand: do we have all of checks running on NIX - or just toolchains? Can we have all cargo-based checks migrated to NIX?
|
Yeah, other actions are updated, and this PR is not MSRV anymore. |
16b4d7d to
871dc31
Compare
6df0e70 to
026176b
Compare
Uh oh!
There was an error while loading. Please reload this page.