Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reading the whole REVLOG into a buffer, then writing the whole output WPILOG to a buffer, then writing the buffer to an output file or passing it on to whatever called it (very large buffers, lots of memory, potential for crashes with large enough files), this uses streams and an accumulator to parse chunks at a time.
This removes the options of passing in or receiving a Buffer, and users should either pass in/receive out streams or files.
Resolves #1
Draft for now until I can get more testing in, and test the change with Ascope. Works locally with files that made previous version crash. Supposedly the
for awaitloop removes the need for thesetImmediatecall, but that still needs to be verified.