Skip to content

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented Dec 9, 2025

What is it?

  • Bug

Description

It used to be like that and got removed by inadvertance in e33abbb I think. This causes some cypress component tests to fail because of unhandled rejection errors.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner December 9, 2025 20:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

🦋 Changeset detected

Latest commit: 7d62aa2

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8197
npm i https://pkg.pr.new/@builder.io/qwik-city@8197
npm i https://pkg.pr.new/eslint-plugin-qwik@8197
npm i https://pkg.pr.new/create-qwik@8197

commit: 0142532

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 7d62aa2

Copy link
Contributor

@JerryWu1234 JerryWu1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks solid. By attaching a dummy catch. we prevent the runtime from flagging the promise as "unhandled" before our custom onRejected handler has a chance to process the state.
Nit: Please add a comment like // Suppress unhandled rejection warning above the line so future contributors don't remove it thinking it's mistake

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 246b4e4 into QwikDev:main Dec 10, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants