-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(create-qwik): add missing execa dependency #8196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only place execa is used is in https://github.com/QwikDev/qwik/blob/build/v2/packages/qwik/src/cli/utils/run-build-command.ts
I think the correct fix is to mark execa as noExternal for qwik/create-qwik so that it is tree shaken and less deps need to be installed before creating a new qwik app.
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Due to the CJS dynamic require() in execa's dependency chain, it cannot be bundled into an ESM bundle. |

After PR #8103 migrated from CJS to ESM, the execa package was marked as external in the esbuild config but was not declared as a dependency in create-qwik's package.json.
This caused 'Cannot find package execa' error when running: npx [email protected]
Fixes the runtime error by adding execa to dependencies.
What is it?
Description
Checklist
pnpm change