Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 25, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: b5d2bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo moved this from Backlog to In progress in Qwik Development Nov 25, 2025
@wmertens wmertens force-pushed the v2-cursors branch 5 times, most recently from 01d87f3 to ea16016 Compare November 26, 2025 15:15
wmertens and others added 6 commits November 26, 2025 16:40
- add cursor management
- remove chore based scheduler
- refactor VNode
- remove journal

Co-authored-by: Varixo <[email protected]>
@Varixo Varixo linked an issue Dec 7, 2025 that may be closed by this pull request

$setRawState$(id: number, vParent: ElementVNode | VirtualVNode): void {
/**
* The first time we render we need to hoist the styles. (Meaning we need to move all styles from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that break the benefits of html streaming? If you hoist the styles to the top, then all styles need to be downloaded before the html continues rendering. Whereas if only the styles that are needed for the top navbar are loaded then it can be rendered right away.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this does it take all the inline styles that were emitted by use*Styles$ and move them into head, so that they don't interfere with DOM handling.
This is the way it is in v1 as well, and it should not have any effect on page loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

[🐞] v2: render function behavior

4 participants