-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: cursor based scheduling #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build/v2
Are you sure you want to change the base?
Conversation
|
01d87f3 to
ea16016
Compare
Co-authored-by: Varixo <[email protected]>
Co-authored-by: Varixo <[email protected]>
Co-authored-by: Varixo <[email protected]>
Co-authored-by: Varixo <[email protected]>
- add cursor management - remove chore based scheduler - refactor VNode - remove journal Co-authored-by: Varixo <[email protected]>
|
|
||
| $setRawState$(id: number, vParent: ElementVNode | VirtualVNode): void { | ||
| /** | ||
| * The first time we render we need to hoist the styles. (Meaning we need to move all styles from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that break the benefits of html streaming? If you hoist the styles to the top, then all styles need to be downloaded before the html continues rendering. Whereas if only the styles that are needed for the top navbar are loaded then it can be rendered right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this does it take all the inline styles that were emitted by use*Styles$ and move them into head, so that they don't interfere with DOM handling.
This is the way it is in v1 as well, and it should not have any effect on page loading.
No description provided.